This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fixed regression for extensions. Updated docs to remove the rootURL … #1463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request address an issue with extensions. The issue has to do with the following code that does the token replacement for EXTENSION_LOOP_COUNT.
Original Replace Code
Template that has the token that is being replaced - template-link.json
In the event that the code that is replacing the token is an expression, everything is fine. In the event that the code that the replacing code is an integer, this causes and error. An integer cannot be surrounded by quotes. This causes extensions such as hello-world-dcos to fail on deployment. See failing code below:
Updated Code
The changed code simply checks the replacing code to see if it is an integer or not. If it is an integer it replaces the token, along with the surrounding quotes. If not, it simply replaces the token. See below.
2 other files were changed - both documentation - removing the reference to rootURL - which is a development concern.